Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22157 )

Change subject: IMPALA-11265: Part3: Group the Iceberg file descriptors by 
partition
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/22157/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java
File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java:

http://gerrit.cloudera.org:8080/#/c/22157/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@130
PS1, Line 130:     private final Map<HashCode, List<EncodedFileDescriptor>> 
fileDescMap_ = new HashMap<>();
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I276d839335c0aa39fa31a06ce08588a91a313768
Gerrit-Change-Number: 22157
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 03 Dec 2024 13:54:14 +0000
Gerrit-HasComments: Yes

Reply via email to