Riza Suminto has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/22128


Change subject: IMPALA-13585: Make pip_download.py interruptible
......................................................................

IMPALA-13585: Make pip_download.py interruptible

infra/python/deps/pip_download.py use multiprocessing.pool.ThreadPool
where each thread calls wget. It is also wrap the download_package
function with retry wrapper. When there is a network issue happen,
pressing Ctrl+C does not immediately terminate pip_download.py and all
its children. Thus, the script appears to hang.

This patch make pip_download.py to capture SIGINT and pass it as
cancellation event to all threads. It is changed to run with python3.
All flake8 issues are also fixed.

Testing:

- Manually run `buildall.sh -cmake_only` and interrupt it in the middle
  of pip_download.py execution. Verify that script terminate
  immediately.

Change-Id: I6f293dd8f3fcf3cffa17a4a44627a41d67b7dc91
---
M infra/python/deps/pip_download.py
1 file changed, 35 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/22128/1
--
To view, visit http://gerrit.cloudera.org:8080/22128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f293dd8f3fcf3cffa17a4a44627a41d67b7dc91
Gerrit-Change-Number: 22128
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <[email protected]>

Reply via email to