Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/22084 )
Change subject: IMPALA-13500: Fix test_invalidate_stale_partition_on_reload() test ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/22084/2/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22084/2/tests/custom_cluster/test_events_custom_configs.py@1318 PS2, Line 1318: .format(test_tbl)) : self.client.execute("a > There are some events metrics exposed by CatalogD We can verify a couple of metrics, like partitions-refreshed and events-skipped, before and after, but doing so will only make the test fail prematurely instead of passing if there is a lag in asynchronous file reload. http://gerrit.cloudera.org:8080/#/c/22084/2/tests/custom_cluster/test_events_custom_configs.py@1327 PS2, Line 1327: l > flake8: E261 at least two spaces before inline comment Ack http://gerrit.cloudera.org:8080/#/c/22084/2/tests/custom_cluster/test_events_custom_configs.py@1330 PS2, Line 1330: self.assert_impalad_log_contains('INFO', log_regex % 1, > Rather than sleeping in test code, it is better to raise timeout_s > 6s par Ack http://gerrit.cloudera.org:8080/#/c/22084/4/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22084/4/tests/custom_cluster/test_events_custom_configs.py@1327 PS4, Line 1327: % test_tbl > Lets drop this sleep(5) and increase timeout_s=20 in L1331. Ack -- To view, visit http://gerrit.cloudera.org:8080/22084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62170aa6ed8ae122482a03212fec9c4fe843ce03 Gerrit-Change-Number: 22084 Gerrit-PatchSet: 5 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2024 06:07:56 +0000 Gerrit-HasComments: Yes
