Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22101 )

Change subject: PROTOTYPE: Add Calcite end-to-end tests
......................................................................


Patch Set 2:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/22101/2/tests/query_test/test_tpch_queries.py
File tests/query_test/test_tpch_queries.py:

http://gerrit.cloudera.org:8080/#/c/22101/2/tests/query_test/test_tpch_queries.py@31
PS2, Line 31: @pytest.mark.calcite_compatible
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/22101/2/tests/query_test/test_tpch_queries.py@51
PS2, Line 51: \
flake8: E502 the backslash is redundant between brackets



--
To view, visit http://gerrit.cloudera.org:8080/22101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87400a9bc602b6320c1625448874e76c6caad392
Gerrit-Change-Number: 22101
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 25 Nov 2024 17:50:30 +0000
Gerrit-HasComments: Yes

Reply via email to