Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )
Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl ...................................................................... Patch Set 1: (2 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG@8 PS1, Line 8: IcebergMergeImpl nit: there shouldn't be a line break http://gerrit.cloudera.org:8080/#/c/22039/1//COMMIT_MSG@15 PS1, Line 15: Tests Could you please add simple e2e tests as well where we could check the results? Could you please also add tests for the case when the source table is masked/filtered, e.g. like in https://gerrit.cloudera.org/#/c/20127/3/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test -- To view, visit http://gerrit.cloudera.org:8080/22039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5 Gerrit-Change-Number: 22039 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2024 17:29:13 +0000 Gerrit-HasComments: Yes
