Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22070 )
Change subject: IMPALA-13448: Log cause when failing to flush lineage events, audit events or profiles ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22070/7/tests/custom_cluster/test_logging.py File tests/custom_cluster/test_logging.py: http://gerrit.cloudera.org:8080/#/c/22070/7/tests/custom_cluster/test_logging.py@75 PS7, Line 75: ORIGINAL_PERMISSIONS Let's not define this as a class variable because it could in principle be specific to each test. We could simply define 'self.orig_permissions' in setup_method() and use it in teardown_method(). http://gerrit.cloudera.org:8080/#/c/22070/7/tests/custom_cluster/test_logging.py@85 PS7, Line 85: tem_dir This should be 'tmp_dir'. -- To view, visit http://gerrit.cloudera.org:8080/22070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b281d807e47aad98fc256af4e0c2a9dd417c7ac Gerrit-Change-Number: 22070 Gerrit-PatchSet: 7 Gerrit-Owner: jiangwei <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2024 15:10:35 +0000 Gerrit-HasComments: Yes
