Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22084 )
Change subject: IMPALA-13500: Fix test_invalidate_stale_partition_on_reload() test ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22084/2/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22084/2/tests/custom_cluster/test_events_custom_configs.py@1327 PS2, Line 1327: time.sleep(2) # file metadata reload runs asynchronously, so wait for 2s Are you sure 2 seconds is enough? Keep in mind that assert_impalad_log_contains already wait for 6 seconds. def assert_impalad_log_contains(self, level, line_regex, expected_count=1, timeout_s=6, dry_run=False): http://gerrit.cloudera.org:8080/#/c/22084/2/tests/custom_cluster/test_events_custom_configs.py@1330 PS2, Line 1330: self.assert_impalad_log_contains('INFO', log_regex % 0) Rather than sleeping in test code, it is better to raise timeout_s > 6s parameter in this first assert_impalad_log_contains. Please loop the test several times to confirm that increased timeout_s is sufficient. -- To view, visit http://gerrit.cloudera.org:8080/22084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62170aa6ed8ae122482a03212fec9c4fe843ce03 Gerrit-Change-Number: 22084 Gerrit-PatchSet: 2 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 19:36:33 +0000 Gerrit-HasComments: Yes
