Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21869 )

Change subject: IMPALA-11265: Part2: Store Iceberg file descriptors in encoded 
format
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21869/3/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java:

http://gerrit.cloudera.org:8080/#/c/21869/3/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java@20
PS3, Line 20: import java.util.ArrayList;
> Unused import
Done


http://gerrit.cloudera.org:8080/#/c/21869/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java
File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java:

http://gerrit.cloudera.org:8080/#/c/21869/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@595
PS3, Line 595: ,
> Could you please add an error message, so we won't only get IllegalStateExc
Done



--
To view, visit http://gerrit.cloudera.org:8080/21869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d7794df999bdaf118158eace26cea610f911c0a
Gerrit-Change-Number: 21869
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:21:34 +0000
Gerrit-HasComments: Yes

Reply via email to