Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22081 )
Change subject: PROTOTYPE: Fix tarfile.ReadError on Ubuntu 20.04 ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22081/8//COMMIT_MSG@12 PS8, Line 12: 2. This stops testing impala-shell with system python 2. > So this preserves building and running tests with impala-python, but stops Right, this doesn't touch toolchain python 2, and that is still used for running pytests and various other things. We use system python 2 for shell tests (with the shell tarball and also with a pip installed impala-shell). This stops testing impala-shell with system python 2, so the only testing configurations for impala-shell would be system python 3. This would impact what we ship in the shell tarball. The shell tarball would no longer include python 2 support. So, I think I would also need to change the tarball's impala-shell executable to only care about python3. -- To view, visit http://gerrit.cloudera.org:8080/22081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e Gerrit-Change-Number: 22081 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:43:08 +0000 Gerrit-HasComments: Yes
