Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22081 )

Change subject: Add logging to pip_download.py and fail if downloads fail
......................................................................


Patch Set 6:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/22081/6/infra/python/bootstrap_virtualenv.py
File infra/python/bootstrap_virtualenv.py:

http://gerrit.cloudera.org:8080/#/c/22081/6/infra/python/bootstrap_virtualenv.py@140
PS6, Line 140: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/22081/6/infra/python/bootstrap_virtualenv.py@141
PS6, Line 141: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/22081/6/infra/python/bootstrap_virtualenv.py@143
PS6, Line 143: #
flake8: E265 block comment should start with '# '



--
To view, visit http://gerrit.cloudera.org:8080/22081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcd09decb749514548bcf7d2ce54db2555a192e
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 20 Nov 2024 03:40:07 +0000
Gerrit-HasComments: Yes

Reply via email to