Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22052 )
Change subject: IMPALA-13540: Calcite planner: fix wrong results for set operators ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22052/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22052/2//COMMIT_MSG@16 PS2, Line 16: Calcite was returning 2 results here, performing the intersect before nit: 'results' seems unclear. Can we say 'rows' ? http://gerrit.cloudera.org:8080/#/c/22052/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java: http://gerrit.cloudera.org:8080/#/c/22052/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java@227 PS2, Line 227: // than union and except. Impala has equal precedence for all the set operators. For future reference, the SQL standard does put INTERSECT at higher precedence than UNION and EXCEPT. Vendor specific behavior: MySQL follows the standard: https://dev.mysql.com/doc/refman/8.4/en/set-operations.html Redshift also follows the standard: https://docs.aws.amazon.com/redshift/latest/dg/r_UNION.html -- To view, visit http://gerrit.cloudera.org:8080/22052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic52661a30cc90534ea1a20868799edf9ceed13b6 Gerrit-Change-Number: 22052 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 18:55:49 +0000 Gerrit-HasComments: Yes
