Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept 
tpcds_partitioned
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22061/2/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/22061/2/testdata/bin/generate-schema-statements.py@623
PS2, Line 623:
             :   hbase_insert = SE
> not used?
I decide to drop 'data_set' entirely and create build_replacement_params() 
helper function for consistency.



--
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Mon, 18 Nov 2024 23:20:16 +0000
Gerrit-HasComments: Yes

Reply via email to