Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21474 )
Change subject: IMPALA-13123: Add option to run tests with Python 3 ...................................................................... Patch Set 6: Code-Review+1 (1 comment) lgtm It would be great to not depend on Python 2. http://gerrit.cloudera.org:8080/#/c/21474/6/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/21474/6/tests/common/test_result_verifier.py@22 PS6, Line 22: str Can you add a comment about what type this will be? Also, maybe something like newstr would be a clearer name to indicate that this is related to Python2/3 compatibility? -- To view, visit http://gerrit.cloudera.org:8080/21474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177d9b8eae9b99ba536ca5c598b07208c3887f8c Gerrit-Change-Number: 21474 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2024 16:06:50 +0000 Gerrit-HasComments: Yes
