Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22076 )
Change subject: IMPALA-11889: Docs for ESRI geospatial functions ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml File docs/topics/impala_geospatial_functions.xml: http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml@41 PS2, Line 41: binary format It could be noted that the format in HIVE_ESRI is compatible with Hive functions with the same name, but this is not guaranteed for new libraries in the future and it is not recommended to serialize geometries in this binary format. For compatibility with other systems converting from/to WKB is recommended. http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml@41 PS2, Line 41: geometries Maybe list the 7 possible geometries + the dimensions? http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml@57 PS2, Line 57: Varags typo: vararg http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml@57 PS2, Line 57: typo http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml@242 PS2, Line 242: e This seems a bit different from https://postgis.net/docs/ST_Overlaps.html http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml@377 PS2, Line 377: <b>Purpose:</b> Calculates the minimum distance between two geometries. Could be noted that this happens in the unit of the coordinate system, so not in metric system? + ST_GeodesicLengthWGS84 could mentioned on how to get metric results. http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml@560 PS2, Line 560: st_ismeasured I am not sure about the documentation of functions related to >2d functions. It may make sense to move them to a different section and not the support for them is limited. http://gerrit.cloudera.org:8080/#/c/22076/2/docs/topics/impala_geospatial_functions.xml@590 PS2, Line 590: <b>Purpose:</b> Returns the length of a LINESTRING geometry. Note that it is not metric? -- To view, visit http://gerrit.cloudera.org:8080/22076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f765927a0856e3034968462514536fd1fffcea5 Gerrit-Change-Number: 22076 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2024 14:32:37 +0000 Gerrit-HasComments: Yes
