Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22049 )
Change subject: WIP IMPALA-10319: Support arbitrary encodings on Text/Sequence files ...................................................................... Patch Set 3: (3 comments) Thanks, should I proceed with expanding it for Sequence and writing? http://gerrit.cloudera.org:8080/#/c/22049/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22049/2//COMMIT_MSG@7 PS2, Line 7: 19: Sup > The patch only adds read support, this could be highlighted in the title. Frankly, at this point it's probably easier to simply add support for writing, mirroring what scanning does. http://gerrit.cloudera.org:8080/#/c/22049/2//COMMIT_MSG@9 PS2, Line 9: As prop > In Impala project the non-final status of a patch is usually marked in the Done http://gerrit.cloudera.org:8080/#/c/22049/2//COMMIT_MSG@23 PS2, Line 23: logic simpler, on the negative side it renders Hive files not readable I haven't found the concrete code for this in Hive yet. I was able to debug some parts of code but not all of the code. Technically in this scope we should just reflect the state of art Hive behavior whatever that is. But can we push this Jira issue you found to Hive folks to give an answer? > but I see no valid reason behind including BOM in every line yes, that's almost certainly a bug. -- To view, visit http://gerrit.cloudera.org:8080/22049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I787cd01caa52a19d6645519a6cedabe0a5253a65 Gerrit-Change-Number: 22049 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Comment-Date: Sun, 17 Nov 2024 10:53:58 +0000 Gerrit-HasComments: Yes
