Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22070 )
Change subject: IMPALA-13448: Logged cause when fails to flush lineage events, audit events or profiles ...................................................................... Patch Set 1: (15 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22070/1/be/src/util/simple-logger.cc File be/src/util/simple-logger.cc: http://gerrit.cloudera.org:8080/#/c/22070/1/be/src/util/simple-logger.cc@136 PS1, Line 136: if(log_file_.fail()) return Status("Could not open log file: " + log_file_name_ + ", " +strerror(errno)); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py File tests/custom_cluster/test_logging.py: http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@82 PS1, Line 82: T flake8: F821 undefined name 'TestLogFlushFailures' http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@84 PS1, Line 84: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@84 PS1, Line 84: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@86 PS1, Line 86: _ flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@86 PS1, Line 86: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@87 PS1, Line 87: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@110 PS1, Line 110: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@110 PS1, Line 110: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@113 PS1, Line 113: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@113 PS1, Line 113: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@114 PS1, Line 114: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@114 PS1, Line 114: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@115 PS1, Line 115: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22070/1/tests/custom_cluster/test_logging.py@115 PS1, Line 115: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/22070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b281d807e47aad98fc256af4e0c2a9dd417c7ac Gerrit-Change-Number: 22070 Gerrit-PatchSet: 1 Gerrit-Owner: jiangwei <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2024 05:00:23 +0000 Gerrit-HasComments: Yes
