Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update stats when loading an HDFS table ...................................................................... Patch Set 12: (1 comment) > Patch Set 12: > > (1 comment) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22014/12/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/22014/12/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1615 PS12, Line 1615: Preconditions.checkState(fileMetadataStats_ == null); : fileMetadataStats_ = new FileMetadataStats(); : fileMetadataStats_.add(descriptors); > Can we simply set FileMetadataStats based on the descriptor list? I.e. add Thanks! Currently there is only one FileMetadataStats in HdfsPartition, and null is used to determine whether the corresponding FileMetadataStats in Builder should be merged into the FileMetadataStats in HdfsPartition. -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 12 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2024 02:21:02 +0000 Gerrit-HasComments: Yes
