Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22060 )
Change subject: IMPALA-5792: Eliminate duplicate beeswax python code ...................................................................... IMPALA-5792: Eliminate duplicate beeswax python code This patch unify duplicated exec summary code used by python beeswax clients: one used by the shell in impala_shell.py and one used by tests in impala_beeswax.py. The code that has progress furthest is the one in shell/impala_client.py, which is the one that can print correct exec summary table for MT_DOP>0 queries. It is made into a dedicated build_exec_summary_table function in impala_client.py, and then impala_beeswax.py import it from impala_client.py. This patch also fix several flake8 issues around the modified files. Testing: - Manually run TPC-DS Q74 in impala-shell and then type "summary" command. Confirm that plan tree is displayed properly. - Run single_node_perf_run.py over branches that produce different TPC-DS Q74 plan tree. Confirm that the plan tree are displayed correctly in performance_result.txt Change-Id: Ica57c90dd571d9ac74d76d9830da26c7fe20c74f Reviewed-on: http://gerrit.cloudera.org:8080/22060 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Daniel Becker <[email protected]> --- M shell/impala_client.py M shell/impala_shell.py M tests/beeswax/impala_beeswax.py 3 files changed, 219 insertions(+), 288 deletions(-) Approvals: Impala Public Jenkins: Verified Daniel Becker: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ica57c90dd571d9ac74d76d9830da26c7fe20c74f Gerrit-Change-Number: 22060 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
