Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22060 )
Change subject: IMPALA-5792: Eliminate duplicate beeswax python code ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22060/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/22060/1/shell/impala_client.py@210 PS1, Line 210: label_prefix, : node.label Before this change, these two strings were concatenated - as far as I can see it they need to be concatenated when called by build_summary_table() but they should be separate for ImpalaBeeswaxClient.__build_summary_table(). Maybe we could pass a parameter to this function to decide this, and then we wouldn't have to copy the lists in self.build_summary_table(). http://gerrit.cloudera.org:8080/#/c/22060/1/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/22060/1/tests/beeswax/impala_beeswax.py@255 PS1, Line 255: for row in result: Optional: Instead of this, you could define a list with the keys: keys = ['prefix', 'operator', ...] And then summ_map = dict(zip(keys, row)) http://gerrit.cloudera.org:8080/#/c/22060/1/tests/beeswax/impala_beeswax.py@256 PS1, Line 256: 11 We could use "len(row)" instead of a constant. -- To view, visit http://gerrit.cloudera.org:8080/22060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica57c90dd571d9ac74d76d9830da26c7fe20c74f Gerrit-Change-Number: 22060 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 14:52:48 +0000 Gerrit-HasComments: Yes
