Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22008 )
Change subject: IMPALA-13471: test_enable_reading_puffin() seems to fail in the Ozone build ...................................................................... Patch Set 3: Code-Review+2 (1 comment) LGTM! http://gerrit.cloudera.org:8080/#/c/22008/2/tests/util/iceberg_metadata_util.py File tests/util/iceberg_metadata_util.py: http://gerrit.cloudera.org:8080/#/c/22008/2/tests/util/iceberg_metadata_util.py@144 PS2, Line 144: def add_prefix_to_statistics(table_params, statistics): : statistics['statistics-path'] = generate_new_path( : table_params, statistics['statistics-path']) : return statistics > I only saw rewrite_metadata() used with on-the-fly tables, but it would pos I meant that with this change the pre-loaded tables might be modifified correctly when the snapshot is loaded, as testdata/bin/load-test-warehouse-snapshot.sh invokes rewrite-iceberg-metadata.py which uses these functions. But I think it's better to not add tables unnecessarily to the functional_parquet database. -- To view, visit http://gerrit.cloudera.org:8080/22008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7afec1c70d7b43bae98289d65749b01ca720e7f7 Gerrit-Change-Number: 22008 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 12:21:55 +0000 Gerrit-HasComments: Yes
