Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22034 )
Change subject: IMPALA-13516: Fix handling of cast functions ...................................................................... Patch Set 3: Sorry about the late changes here, but I found a bug and a couple of missing things while looking at other issues 1) the check to make the cast return type nullable was flipped. If it's true, we should make the new type nullable 2) Added date and binary to casting functions -- To view, visit http://gerrit.cloudera.org:8080/22034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1edabc942de1c4030331bc29612c41b392cd8a05 Gerrit-Change-Number: 22034 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 11 Nov 2024 15:47:44 +0000 Gerrit-HasComments: No
