Michael Smith has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22025 )
Change subject: IMPALA-13494: Calcite planner group_concat with distinct failing
......................................................................
IMPALA-13494: Calcite planner group_concat with distinct failing
The following query is failing.
select sum(len_orderkey), sum(len_comment)
from (
select
length(group_concat(distinct cast(l_orderkey as string))) len_orderkey,
length(group_concat(distinct(l_comment))) len_comment
from tpch.lineitem
group by l_comment
) v
There is code where in AggregationFunction for group_concat that calls
to ignore an implicit cast. The 'isImplicitCast_' member is being used
directly in this function, but the variable is overridden in the
isImplicitCast method for the Calcite planner. A small change was needed
to call the isImplicitCast() function rather than use the member variable.
Change-Id: Idec41597b40a533bc0774b4ff2ab5059c7f324e2
Reviewed-on: http://gerrit.cloudera.org:8080/22025
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idec41597b40a533bc0774b4ff2ab5059c7f324e2
Gerrit-Change-Number: 22025
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
