Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21932 )
Change subject: IMPALA-13509: Copy rows directly to OutboundRowBatch during hash partitioning ...................................................................... Patch Set 12: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21932/9/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21932/9/be/src/runtime/krpc-data-stream-sender.cc@602 PS9, Line 602: // Measure the time needed after getting the lock. > Replaced counter with RpcSuccess. I could see an argument for both being useful. It's helpful to know how many TransmitData messages have been started, and compare against RPC success. But I guess it's usually one at a time so sent would always be 1 less than or equal to success+failure. -- To view, visit http://gerrit.cloudera.org:8080/21932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a16c2f0fcfc1f3adef7077b3932a29a0f15a8f Gerrit-Change-Number: 21932 Gerrit-PatchSet: 12 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 19:24:41 +0000 Gerrit-HasComments: Yes
