Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22010 )
Change subject: IMPALA-13502: Clean up around constructors ...................................................................... IMPALA-13502: Clean up around constructors Makes 'name' a required parameter around CreateBinaryPhiNode, CodegenNullPhiNode, and CodegenIsNullPhiNode to skip rare case where we generate a name. Uses raw pointers or const& rather than const shared_ptr& in some cases to simplify API. Removes unused TSaslServerTransport constructors. Reuses CharMemTrackerAllocator and OutboundRowBatch in TupleFileWriter. Change-Id: I4321888808a6b26f42664163e1d1fa137dbc7d14 Reviewed-on: http://gerrit.cloudera.org:8080/22010 Reviewed-by: Riza Suminto <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/benchmarks/row-batch-serialize-benchmark.cc M be/src/codegen/codegen-anyval-read-write-info.h M be/src/codegen/codegen-anyval.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/hash-table.cc M be/src/exec/tuple-file-writer.cc M be/src/exec/tuple-file-writer.h M be/src/rpc/TAcceptQueueServer.cpp M be/src/rpc/TAcceptQueueServer.h M be/src/runtime/krpc-data-stream-sender.cc M be/src/runtime/outbound-row-batch.h M be/src/runtime/row-batch-serialize-test.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/transport/TSaslServerTransport.cpp M be/src/transport/TSaslServerTransport.h 17 files changed, 71 insertions(+), 99 deletions(-) Approvals: Riza Suminto: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4321888808a6b26f42664163e1d1fa137dbc7d14 Gerrit-Change-Number: 22010 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
