Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21665 )
Change subject: IMPALA-12865: enable_reload_events breaks enable_skipping_older_events by pushing lastRefreshEventId too high ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21665/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21665/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7176 PS3, Line 7176: l.getFullName()); > Is it possible for this to be -1? Yeah, if we cannot get the latest event id from HMS, then it is possible for currentHMSEventId to be -1. https://gerrit.cloudera.org/c/21665/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#7015 http://gerrit.cloudera.org:8080/#/c/21665/3/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21665/3/tests/custom_cluster/test_events_custom_configs.py@1210 PS3, Line 1210: self.client.execute("alter table {} add partition(year=2024)".format(tbl)) : EventProcessorUtils.wait_for_event_processing(self) : self.client.execute_async("refresh {} partition(year=2024)".format(tbl)) > Did this actually reproduce the bug before the fix? As alter table is after I have added a delay in the latest patch set to repro this issue more deterministically. You can undo the changes in CatalogOpExecutor class and you'll see that this test fails always. -- To view, visit http://gerrit.cloudera.org:8080/21665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b Gerrit-Change-Number: 21665 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2024 22:41:14 +0000 Gerrit-HasComments: Yes
