Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22031 )

Change subject: IMPALA-13513: Support decode function
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/22031/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java:

http://gerrit.cloudera.org:8080/#/c/22031/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java@214
PS2, Line 214:           ? 
Lists.newArrayList(ImpalaTypeConverter.createImpalaType(argTypes.get(caseOperandNum)))
line too long (98 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3b68fda7cfa14799a41428e35d5bbc5984a801a
Gerrit-Change-Number: 22031
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Tue, 05 Nov 2024 20:07:50 +0000
Gerrit-HasComments: Yes

Reply via email to