Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22015 )
Change subject: IMPALA-13507: Allow disabling glog buffering via with_args fixture ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/22015/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22015/5//COMMIT_MSG@36 PS5, Line 36: test_query_live.py is modified to wait for few seconds until Please explain the reason behind this modification. http://gerrit.cloudera.org:8080/#/c/22015/5/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/5/tests/common/custom_cluster_test_suite.py@175 PS5, Line 175: if reset_ranger: This change (and also for impalad_graceful_shutdown) is a backwards-compatibility breaking change because it switches the handling of `None`. Previously, if either parameter was `None`, then the code used `True` (since None is not False). Now, the uses `False` since the if statements evaluate `None` as `False`. I wanted to call this change out for discussion, but I do not see any problem with it because: 1. No test sets `reset_ranger` or `impalad_graceful_shutdown` to `None`. Thus, all tests will continue working as is. 2. This is test code. 3. Using a value of `False` for `None` makes more sense. http://gerrit.cloudera.org:8080/#/c/22015/5/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/5/tests/common/impala_test_suite.py@1370 PS5, Line 1370: LOG.warning( Please add details on setting `disable_log_buffering=True` in custom cluster tests. -- To view, visit http://gerrit.cloudera.org:8080/22015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56fb1746b8f3cea9f3db3514a86a526dffb44a61 Gerrit-Change-Number: 22015 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 19:18:24 +0000 Gerrit-HasComments: Yes
