Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22015 )
Change subject: IMPALA-13507: Allow disabling glog buffering via with_args fixture ...................................................................... Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/22015/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22015/1//COMMIT_MSG@20 PS1, Line 20: with '-logbuflevel=-1' for all daemons. If it is False, log WARNING on I imagine most of the tests only check one daemon's log. But I don't see any harm in setting this on all daemons for short custom cluster tests. http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/custom_cluster_test_suite.py@177 PS1, Line 177: if impalad_graceful_shutdown: Why change this one but not reset_ranger? http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/impala_test_suite.py@182 PS1, Line 182: # If True, call to assert_log_contains() will print WARN log for possibillity of typo: possibility http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/impala_test_suite.py@1370 PS1, Line 1370: LOG.warning("{} calls assert_log_contains(). Make sure that glog buffering has " Does this essentially push us to move these to custom cluster tests? -- To view, visit http://gerrit.cloudera.org:8080/22015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56fb1746b8f3cea9f3db3514a86a526dffb44a61 Gerrit-Change-Number: 22015 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 15:50:26 +0000 Gerrit-HasComments: Yes
