Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22006 )
Change subject: IMPALA-13503: CustomClusterTestSuite for whole class ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22006/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22006/1/tests/common/custom_cluster_test_suite.py@182 PS1, Line 182: if impalad_graceful_shutdown is not False: > I should probably add a comment here, it's where the magic happens. Done http://gerrit.cloudera.org:8080/#/c/22006/1/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/22006/1/tests/custom_cluster/test_tuple_cache.py@691 PS1, Line 691: # The extra scan range means that at least one fragment instance key changed > We could collapse test suites a bit more if we settled on a few configurati I think test_tuple_cache_key_with_stats in particular depends on multiple scanners, so it only works with mt_dop=0 or 2. -- To view, visit http://gerrit.cloudera.org:8080/22006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a08694edcf8cc340d89a0fb33beb8229163b356 Gerrit-Change-Number: 22006 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 19:24:03 +0000 Gerrit-HasComments: Yes
