Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/codegen/llvm-codegen.cc@697 PS16, Line 697: llvm::PHINode* LlvmCodeGen::CreateBinaryPhiNode(LlvmBuilder* builder, llvm::Value* value1, : llvm::Value* value2, llvm::BasicBlock* incoming_block1, : llvm::BasicBlock* incoming_block2, const string& name) { > Seems reasonable, I think there's only one that omits passing a name and it This patch is pretty huge, and focused on the performance checks. I'll create a ticket to do some separate cleanup. http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/runtime/outbound-row-batch.h File be/src/runtime/outbound-row-batch.h: http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/runtime/outbound-row-batch.h@38 PS16, Line 38: OutboundRowBatch(const std::shared_ptr<CharMemTrackerAllocator>& allocator) > I think seeing a 'const shared_ptr<>&' in general is suspicious, and we cou This patch is pretty huge, and focused on the performance checks. I'll create a ticket to do some separate cleanup. http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/transport/TSaslServerTransport.h File be/src/transport/TSaslServerTransport.h: http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/transport/TSaslServerTransport.h@112 PS16, Line 112: : /** : * Construct a new TSaslTrasnport, passing in the components of the definition. : */ : TSaslServerTransport(std::string mechanism, : std::string protocol, : std::string serverName, : std::string realm, : unsigned flags, : std::map<std::string, std::string> props, : std::vector<struct sasl_callback> callbacks, : std::shared_ptr<TTransport> transport); > I think this constructor is unused now. Please double check. This patch is pretty huge, and focused on the performance checks. I'll create a ticket to do some separate cleanup. http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/transport/TSaslServerTransport.h@152 PS16, Line 152: /** : * Create a new Factor for a server definition. : * Provides a single definition for the server, others may be added. : */ : Factory(const std::string& mechanism, const std::string& protocol, : const std::string& serverName, const std::string& realm, : unsigned flags, std::map<std::string, std::string> props, : std::vector<struct sasl_callback> callbacks) : : TTransportFactory() { : addServerDefinition(mechanism, protocol, serverName, realm, flags, : move(props), move(callbacks)); : } > I think this constructor is unused now. Please double check. This patch is pretty huge, and focused on the performance checks. I'll create a ticket to do some separate cleanup. -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 16 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 17:38:09 +0000 Gerrit-HasComments: Yes
