Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 23: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/20447/23/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/23/be/src/util/openssl-util.cc@271 PS23, Line 271: int in_len = static_cast<int>(min<int64_t>(len - input_offset, numeric_limits<int>::max())); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20447/23/be/src/util/openssl-util.cc@274 PS23, Line 274: EVP_EncryptUpdate(ctx.ctx, out + input_offset, &output_len, data + input_offset, in_len) : line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20447/23/be/src/util/openssl-util.cc@275 PS23, Line 275: EVP_DecryptUpdate(ctx.ctx, out + input_offset, &output_len, data + input_offset, in_len); line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 23 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 09:11:10 +0000 Gerrit-HasComments: Yes
