Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22006 )
Change subject: CustomClusterTestSuite for whole class ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22006/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22006/1/tests/common/custom_cluster_test_suite.py@87 PS1, Line 87: If a @with_args decorator is specified on the class instead of a test method, all tests This all works because we only create one instance of each test class, so we can treat 'cls' and 'self' interchangeably. http://gerrit.cloudera.org:8080/#/c/22006/1/tests/common/custom_cluster_test_suite.py@182 PS1, Line 182: if inspect.isclass(obj): I should probably add a comment here, it's where the magic happens. If obj is a class, we set SHARED_CLUSTER_ARGS and setup_class/teardown_class manage the cluster. Otherwise it's a test function and we attach args to func.__dict__, and don't set SHARED_CLUSTER_ARGS, so setup_method/teardown_method manage the cluster. I should also add a guard against using both in the same class, as that would not work well. http://gerrit.cloudera.org:8080/#/c/22006/1/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/22006/1/tests/custom_cluster/test_tuple_cache.py@691 PS1, Line 691: """Test with single executor and mt_dop=0 or 2.""" We could collapse test suites a bit more if we settled on a few configurations, maybe - cluster_size=1, mt_dop=0 - cluster_size=1, mt_dop=[0, 1, 2] - cluster_size=3, mt_dop=0 - cluster_size=3, mt_dop=[0, 1, 2] I'm not sure what rationale was used for test_tuple_cache_count_star and test_tuple_cache_key_with_stats testing multiple mt_dop values. -- To view, visit http://gerrit.cloudera.org:8080/22006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a08694edcf8cc340d89a0fb33beb8229163b356 Gerrit-Change-Number: 22006 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2024 23:55:43 +0000 Gerrit-HasComments: Yes
