Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21869 )
Change subject: IMPALA-11265: Part2: Store Iceberg file descriptors in encoded format ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21869/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/21869/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@217 PS1, Line 217: public FileDescriptor getDeleteFileDescriptor(String pathHash) { Note to self: Now when we query the same pathHash multiple times, the objects we return won't be the same. This causes some hiccups when we put the FDs for equality deletes into a HashSet and we expect the duplicates being filtered by this. However, since they are different objects the EQ-deletes files will be stored redundantly in the IcebergScanNode that would mean we read some eq-delete files redundantly. This doesn't cause correctness issue fortunately. -- To view, visit http://gerrit.cloudera.org:8080/21869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d7794df999bdaf118158eace26cea610f911c0a Gerrit-Change-Number: 21869 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 13:17:09 +0000 Gerrit-HasComments: Yes
