Yida Wu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21309 )
Change subject: IMPALA-12046: Add profile counter for scan range queueing time on disk queues ...................................................................... IMPALA-12046: Add profile counter for scan range queueing time on disk queues This patch introduces a new timer counter in the query profile to track the time spent by scan ranges in the disk io queues. The solution is to add a timer to each request range and starting and stopping the timer when the request range is in the disk io queue. Each request context will have a queueing timer counter, and every timer associated with the range belonging to the request context will aggregate the time count to this counter. Also adds Reset() function to existing timer to enable fast resetting of the timer. Since ranges are now reusable, it is more efficient to reset the timer instead of reallocating it every time the range is reused. Tests: Manuall tests and it shows the aggregated queueing time in the profile. Added new testcase custom_cluster/test_disk_io_queue.py. Change-Id: Ia0cb24db36cd89933c150b88e166e68a3abc7a60 --- M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-base.h M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/request-context.cc M be/src/runtime/io/request-context.h M be/src/runtime/io/request-ranges.h M be/src/util/runtime-profile-counters.h M be/src/util/stopwatch.h A tests/custom_cluster/test_disk_io_queue.py 9 files changed, 139 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/21309/3 -- To view, visit http://gerrit.cloudera.org:8080/21309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia0cb24db36cd89933c150b88e166e68a3abc7a60 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
