Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 6: (8 comments) Thanks for your feedbacks! http://gerrit.cloudera.org:8080/#/c/21930/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21930/2//COMMIT_MSG@15 PS2, Line 15: KILL QUERY '123:456'; > Looking at this again, the Jira description has a good outline of the desir Thanks! Added a comment at https://issues.apache.org/jira/browse/IMPALA-12648?focusedCommentId=17892420&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17892420 http://gerrit.cloudera.org:8080/#/c/21930/4/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/4/be/src/service/client-request-state.cc@2446 PS4, Line 2446: > Missing #import <optional> Thanks! Added. http://gerrit.cloudera.org:8080/#/c/21930/4/be/src/service/client-request-state.cc@2446 PS4, Line 2446: } > Coding standard is to not use namespaces in .cc files unless required (due Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/21930/4/be/src/service/client-request-state.cc@2446 PS4, Line 2446: > Is a new import needed for this object? Thanks! Added new imports for std::optional and std::string_view. http://gerrit.cloudera.org:8080/#/c/21930/4/be/src/service/client-request-state.cc@2476 PS4, Line 2476: results.push_back(status); > Can the optional variable requesting_user be reused here? Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/21930/4/be/src/service/client-request-state.cc@2483 PS4, Line 2483: } > May be able to simplify the code by leveraging the GetFilteredExecutorGroup Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/21930/4/be/src/service/client-request-state.cc@2527 PS4, Line 2527: void ClientRequestState::AddTableResetHints(const TConvertTableRequest& params, > Can we return a slightly more descriptive response here, something like "co Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/21930/4/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/21930/4/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@188 PS4, Line 188: analysisResult.setUserHasProfileAccess(false) > It looks like before this patch, setUserHasProfileAccess(false) was mostly/ Thanks! Ideally I think we should only call `setUserHasProfileAccess(false)` for statements that need it. I will check the code later to see whether we can achieve this. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 6 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 24 Oct 2024 10:41:22 +0000 Gerrit-HasComments: Yes
