Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 1: The JSON output from ESLint requires post processing similar to flake8. After confirming some requirements, in the next patchset, I will add the functionality to process this JSON output from ESLint in critique-gerrit-review.py for integration with 'gerrit-auto-critic' jenkins job. Currently, JS tests are using NodeJS installation in the toolchain directory, which should also be utilized for ESLint. -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2024 21:48:14 +0000 Gerrit-HasComments: No
