Xuebin Su has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21755 )
Change subject: IMPALA-13287: Check overflow for bigint arithmetic ...................................................................... IMPALA-13287: Check overflow for bigint arithmetic Previously, Impala would return a wrong query result for bigint arithmetic if the result exceeded the limits of bigint due to overflow. This patch fixes the issue by adding a check in each bigint arithmetic operation, and reporting an error if the result overflowed, rather than returning the wrong result. The check is implemented using the compiler built-in functions for efficiency. Testing - Added test cases for bigint addition, substraction, and multiplication in the query test. Change-Id: Iaf22bef737caeab241ac3c708f43c5a72bb22350 --- M be/src/benchmarks/expr-benchmark.cc M be/src/exprs/operators-ir.cc M testdata/workloads/functional-query/queries/QueryTest/overflow.test 3 files changed, 72 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/21755/3 -- To view, visit http://gerrit.cloudera.org:8080/21755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaf22bef737caeab241ac3c708f43c5a72bb22350 Gerrit-Change-Number: 21755 Gerrit-PatchSet: 3 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]>
