Hello Abhishek Rawat, Csaba Ringhofer, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21966
to look at the new patch set (#2).
Change subject: IMPALA-13469: Deflake test_query_cpu_count_on_insert
......................................................................
IMPALA-13469: Deflake test_query_cpu_count_on_insert
A new test case from IMPALA-13445 reveals a pre-existing issue where
cost-based planning may increase expectedNumInputInstance greater than
inputFragment.getNumInstances(), which leads to precondition violation.
This happens in the special case where cost-based planning is enabled,
num fragments before adding DML fragment is just one, and it has
HdfsScanNode. That special case should only reduce
expectedNumInputInstance rather than increase.
There is also a new bug where DistributedPlanner.java mistakenly passes
root.getInputCardinality() instead of root.getCardinality().
This patch fixes both issues and does minor refactoring to change
variable names into camel cases. The last test case of
test_query_cpu_count_on_insert is removed because it yields different
pool assignments in EC and Ozone setup. It has been replaced with new
Planner tests placed at tpcds-ddl-iceberg.test and
tpcds-ddl-parquet.test.
Testing:
- Make several assertion in test_executor_groups.py more verbose.
- Pass test_executor_groups.py in EC and Ozone setup.
- Pass core tests in regular setup.
Change-Id: I834eb6bf896752521e733cd6b77a03f746e6a447
---
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M
testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-ddl-iceberg.test
M
testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-ddl-parquet.test
M tests/custom_cluster/test_executor_groups.py
4 files changed, 292 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/21966/2
--
To view, visit http://gerrit.cloudera.org:8080/21966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I834eb6bf896752521e733cd6b77a03f746e6a447
Gerrit-Change-Number: 21966
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
