Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21964 )

Change subject: IMPALA-13467: Fix partition size calculation for empty Iceberg 
scan nodes
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21964/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21964/1//COMMIT_MSG@7
PS1, Line 7: size
This first made me think it was about the sizes of individual partitions, not 
the number of partitions. I think it should be made clearer.
Applies to other places too.


http://gerrit.cloudera.org:8080/#/c/21964/1//COMMIT_MSG@12
PS1, Line 12: ,
I thinks it's better to start a new sentence here.



--
To view, visit http://gerrit.cloudera.org:8080/21964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0595831f3bd87074144ab7d5da27508e73ef33
Gerrit-Change-Number: 21964
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Tue, 22 Oct 2024 12:09:14 +0000
Gerrit-HasComments: Yes

Reply via email to