Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21864 )
Change subject: IMPALA-13340: Fix missing partitions in COPY TESTCASE of LocalCatalog mode ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG@37 PS4, Line 37: When catalogd processes the getPartitalCatalog requests on the imported typo: getPartialCatalog http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG@49 PS4, Line 49: Tests Should there also be a new LocalCatalog mode test? http://gerrit.cloudera.org:8080/#/c/21864/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/21864/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1074 PS4, Line 1074: // have a null cachedMsPartitionDescriptor. The comment is no longer clear, since we don't check cachedMsPartitionDescriptor. http://gerrit.cloudera.org:8080/#/c/21864/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/21864/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@543 PS4, Line 543: super.loadFromThrift(thriftTable, loadedInImpalad); nit: could this change be less invasive if loadedInImpalad were a property of Table.java that you set on creation? -- To view, visit http://gerrit.cloudera.org:8080/21864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc2e8b71564ad37973ddfca92801afea8e26ff73 Gerrit-Change-Number: 21864 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 21 Oct 2024 20:34:05 +0000 Gerrit-HasComments: Yes
