Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21947 )
Change subject: IMPALA-13462: Added support for functions used in tpcds ...................................................................... IMPALA-13462: Added support for functions used in tpcds The tpcds queries contain some functions that require some modifications that the general function resolver cannot handle. These include: - Some functions don't have the same name within Calcite. An example of this is "is_not_null" which is "is_not_null_pred" in Impala. - The grouping function returns a tinyint in Impala which is different from Calcite. - The params for functions that adjust the scale (e.g. ROUND) need to handle casting of parameters in the Impala way which is different from Calcite. Also handled in this commit is turning on the identifier expansion in the Calcite validator. This is needed to fix some of the tpcds queries as well. Change-Id: Id451357f2fb92d35e09b100751f0f4a49760a51c Reviewed-on: http://gerrit.cloudera.org:8080/21947 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaGroupingFunction.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperator.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteValidator.java 6 files changed, 197 insertions(+), 32 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id451357f2fb92d35e09b100751f0f4a49760a51c Gerrit-Change-Number: 21947 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
