Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21927 )
Change subject: IMPALA-13445: Ignore num partition for unpartitioned writes ...................................................................... Patch Set 6: Code-Review+1 (3 comments) The code LGTM, but had a few questions. http://gerrit.cloudera.org:8080/#/c/21927/6/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java File fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java: http://gerrit.cloudera.org:8080/#/c/21927/6/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java@453 PS6, Line 453: shuflfing nit: typo http://gerrit.cloudera.org:8080/#/c/21927/6/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java@457 PS6, Line 457: maxWriters = totalNumPartitions Shouldn't we set maxWriters higher, e.g. totalNumPartitions * 2, to limit hash collisions and balance the load better between writers? Base version already has this problem so it doesn't need to be solved by this patch, I just wanted to raise this question. http://gerrit.cloudera.org:8080/#/c/21927/6/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-ddl-iceberg.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-ddl-iceberg.test: http://gerrit.cloudera.org:8080/#/c/21927/6/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-ddl-iceberg.test@283 PS6, Line 283: hosts=10 instances=10 Why is it 10 hosts and 10 instances when we have only a single input file? -- To view, visit http://gerrit.cloudera.org:8080/21927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab8fc35a5489351a88d372b28642b35449acfc Gerrit-Change-Number: 21927 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2024 19:35:47 +0000 Gerrit-HasComments: Yes
