Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 )
Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot ...................................................................... Patch Set 34: Code-Review+1 (2 comments) Few nits, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/21605/34/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/21605/34/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@72 PS34, Line 72: the nit: redundant 'the' http://gerrit.cloudera.org:8080/#/c/21605/34/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@503 PS34, Line 503: !colType.isBoolean() : && !colType.isBinary() Could be moved to a method like 'ColumnStats.supportsNdv(Type colType)' -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 34 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2024 11:20:32 +0000 Gerrit-HasComments: Yes
