Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21953 )
Change subject: IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples ...................................................................... IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples Removed the DCHECK assertion that tuple_data_len must be greater than zero in tuple-file-writer.cc and tuple-file-reader.cc, because in certain cases, such as count(*), tuple_data_len can be zero, as no column data is returned and only the row count matters. Tests: Adds TestTupleCacheCountStar for the regression test. Change-Id: I264b537f0eb678b65081e90c21726198f254513d Reviewed-on: http://gerrit.cloudera.org:8080/21953 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/tuple-file-reader.cc M be/src/exec/tuple-file-writer.cc M tests/custom_cluster/test_tuple_cache.py 3 files changed, 31 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I264b537f0eb678b65081e90c21726198f254513d Gerrit-Change-Number: 21953 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
