Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 1: (14 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21930/1/common/thrift/Types.thrift File common/thrift/Types.thrift: http://gerrit.cloudera.org:8080/#/c/21930/1/common/thrift/Types.thrift@a113 PS1, Line 113: Modifying/deleting this enum item might break the compatibility between impalad and catalogd/statestore during upgrade PS1: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new optional fields can be added. http://gerrit.cloudera.org:8080/#/c/21930/1/fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java File fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java: http://gerrit.cloudera.org:8080/#/c/21930/1/fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java@78 PS1, Line 78: // masked privilege request fails. This will disallow any non-admin user to line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java@80 PS1, Line 80: // line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/21930/1/tests/common/impala_connection.py@266 PS1, Line 266: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/common/impala_connection.py@266 PS1, Line 266: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/custom_cluster/test_kill_query_custom_cluster.py File tests/custom_cluster/test_kill_query_custom_cluster.py: http://gerrit.cloudera.org:8080/#/c/21930/1/tests/custom_cluster/test_kill_query_custom_cluster.py@25 PS1, Line 25: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/custom_cluster/test_kill_query_custom_cluster.py@25 PS1, Line 25: QueryToKill, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/custom_cluster/test_kill_query_custom_cluster.py@26 PS1, Line 26: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/custom_cluster/test_kill_query_custom_cluster.py@26 PS1, Line 26: assert_kill_error, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/custom_cluster/test_kill_query_custom_cluster.py@36 PS1, Line 36: class TestKillQueryCustomCluster(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21930/1/tests/query_test/test_kill_query.py File tests/query_test/test_kill_query.py: http://gerrit.cloudera.org:8080/#/c/21930/1/tests/query_test/test_kill_query.py@49 PS1, Line 49: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/query_test/test_kill_query.py@49 PS1, Line 49: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21930/1/tests/query_test/test_kill_query.py@139 PS1, Line 139: = flake8: E225 missing whitespace around operator -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 1 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 09:13:09 +0000 Gerrit-HasComments: Yes
