Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21908 )
Change subject: IMPALA-13429: Calcite planner crashing with outer join ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21908/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java: http://gerrit.cloudera.org:8080/#/c/21908/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@444 PS2, Line 444: // left side expr may only contain inputrefs from left side. : // right side expr may only contain inputrefs from right side. > A couple nits: Done -- To view, visit http://gerrit.cloudera.org:8080/21908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ae2d257fa58f3a58079b6aa551c32ffda7d28cf Gerrit-Change-Number: 21908 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 20:08:23 +0000 Gerrit-HasComments: Yes
