Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 24: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21426/24/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/24/shell/impala_client.py@770 PS24, Line 770: "close session RPC failed: {0}".format(type(e)), False) can you add stderr_flag= to make the meaning of False clearer? -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 24 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Saurabh Katiyal <[email protected]> Gerrit-Comment-Date: Mon, 07 Oct 2024 15:50:47 +0000 Gerrit-HasComments: Yes
