Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21867 )
Change subject: IMPALA-13408: use a specific flag for the topic prefix cluster identifier. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21867/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21867/2//COMMIT_MSG@16 PS2, Line 16: An important difference is that the query_log cluster_id must be set > Yes, there is nothing preventing this being set, it will just be ignored. I I guess I don't understand how "cluster_id must be set only on coordinators" then. This patch seems more like some semantic cleanup rather than a hard requirement. http://gerrit.cloudera.org:8080/#/c/21867/2//COMMIT_MSG@18 PS2, Line 18: simultaneously on coordinators, executors, and admission daemons > The idea behind IMPALA-13208 is (IIUIC) to have a single catalog service th Oh right. -- To view, visit http://gerrit.cloudera.org:8080/21867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd3f7e1c73c00a7aaeee79ecb461209e3939c422 Gerrit-Change-Number: 21867 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2024 18:45:30 +0000 Gerrit-HasComments: Yes
