Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 )
Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot ...................................................................... Patch Set 15: Code-Review+1 (3 comments) Thanks, Daniel, I left some minor comments. http://gerrit.cloudera.org:8080/#/c/21605/15/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java File fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java: http://gerrit.cloudera.org:8080/#/c/21605/15/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java@19 PS15, Line 19: : import java.io.IOException; : import java.io.UncheckedIOException; unused imports http://gerrit.cloudera.org:8080/#/c/21605/15/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java@33 PS15, Line 33: import org.apache.hadoop.fs.Path; unused import http://gerrit.cloudera.org:8080/#/c/21605/15/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java@142 PS15, Line 142: deserialisation nit: maybe deserialization? -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 15 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2024 14:14:32 +0000 Gerrit-HasComments: Yes
