Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 )
Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/21605/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21605/12//COMMIT_MSG@20 PS12, Line 20: 'disable_reading_puffin_stats' startup flag - when it is set to true, : Impala will never read Puffin stats I think a query option would be more convenient. We usually use query options for disabling/enabling functionalities that are not too critical, and startup flags to disable/enable features that probably require admin privileges (e.g. security knobs). Is there a specific reason why you chose a startup flag? http://gerrit.cloudera.org:8080/#/c/21605/12/tests/custom_cluster/test_iceberg_with_puffin_stats.py File tests/custom_cluster/test_iceberg_with_puffin_stats.py: http://gerrit.cloudera.org:8080/#/c/21605/12/tests/custom_cluster/test_iceberg_with_puffin_stats.py@24 PS12, Line 24: TestIcebergAlwaysAllowMergeOnRead Class name does not fit. -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 12 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 20 Sep 2024 16:13:42 +0000 Gerrit-HasComments: Yes
